docassemble icon indicating copy to clipboard operation
docassemble copied to clipboard

Preserve signature with change in screen orientation and size

Open plocket opened this issue 2 years ago • 5 comments

This works in most cases - the ones that seem most likely. When the user has signed at < 175% zoom and zooms to 175%+, parts of the signature go off screen. This is a nonissue when going the other way.

If this isn't get acceptable, I can keep working on it.

Sorry about the changed compiled files. They're not up to date with the latest changes as I was trying not to commit them, but I must have committed them accidentally at some point. Let me know if I need to reset them.

plocket avatar Jan 27 '23 15:01 plocket

~Couldn't test on an actual phone, just in the browser phone emulators.~ Was able to test on an iphone and that at least worked fine.

plocket avatar Jan 27 '23 16:01 plocket

Sorry, didn't mean to close it.

plocket avatar Jan 27 '23 16:01 plocket

Do I need to resolve bundle conflicts? If so, what's the procedure for that?

plocket avatar Mar 12 '23 12:03 plocket

Done. Maybe a new bundle.js rebase is needed. I assume I just rebase to master?

plocket avatar Jun 25 '23 13:06 plocket

Yeah, the branch I made probably got stale since making it.

BryceStevenWilley avatar Jun 26 '23 14:06 BryceStevenWilley