i18n icon indicating copy to clipboard operation
i18n copied to clipboard

Published 20 hours ago • verified publisher icon jhorstmann

Jdk11 support

Open jarlesat opened this issue 3 years ago • 2 comments

Three changes: Building using JDK8. Upgrades asm to version 7.0, being able to read classes built in JDK11. Slightly better stacktrace from MessageExtractorException

jarlesat avatar Sep 01 '21 14:09 jarlesat

Thanks for the contribution! As you can see I haven't touched this project in quite some time but it's great to see someone still using it.

Do you think it would be possible to already throw the MessageExtractorException with the file name / systemId in the message? From a quick look through github this name should be available when throwing and we don't need to wrap the exception in another layer.

jhorstmann avatar Sep 01 '21 14:09 jhorstmann

I have force pushed a change. I did not see that the filename was available in the InputStream as systemId. In fact I added the filename as a message, because there were an error in two EL-expressions in one of my xhtml-files that I could not see, and JSF has silently accepted for a couple of years. I am testing to see how easy it is to swap out properties-files with po-files.

jarlesat avatar Sep 01 '21 17:09 jarlesat