fast_barcode_scanner icon indicating copy to clipboard operation
fast_barcode_scanner copied to clipboard

Published 20 hours ago • verified publisher icon jhoogstraat

Implement camera switching

Open ikbendewilliam opened this issue 3 years ago • 20 comments

Fixed #4

ikbendewilliam avatar Dec 07 '21 16:12 ikbendewilliam

@Xazin Can you review again? The comments have been fixed

ikbendewilliam avatar Dec 29 '21 11:12 ikbendewilliam

@Xazin Can you review again? The comments have been fixed

@jhoogstraat Is the only one who can merge it, and he also needs to review it.

Also I think you should change the branch you're merging into to develop !

Xazin avatar Dec 29 '21 18:12 Xazin

Yeah, sorry for being to quiet. I am finalizing my master thesis, so after that I will be back working on this plugin. Does this fix issues which are present in the develop branch?

jhoogstraat avatar Dec 29 '21 23:12 jhoogstraat

This is the missing functionality to switch between front and back camera, I am not sure how the develop branch looks, but this indeed does fix this part of the issue on main.

Xazin avatar Dec 29 '21 23:12 Xazin

No worries, that has priority of course! This adds functionality in the current release v1.1.4 (main branch). I haven't tested it on the v2 (develop branch)

ikbendewilliam avatar Dec 30 '21 07:12 ikbendewilliam

Hi @jhoogstraat, I hope you're doing well. In the near future we'd like to use this implementation in a new package, to publish that package this first needs to be merged. For now we use git dependencies 🙂. This isn't priority as you're working on your master thesis, but can you give us an indication of when you would be able to check this? Or, if you prefer, you could give @Xazin merge rights (or someone else ofc). But that's entirely up to you.

ikbendewilliam avatar Feb 07 '22 10:02 ikbendewilliam

Hi, actually I am back right now. I am currently looking through all the comments and changes!

jhoogstraat avatar Feb 07 '22 12:02 jhoogstraat

Any update on this?

ikbendewilliam avatar Feb 28 '22 11:02 ikbendewilliam

I would very much like to merge your pr, but I am still hestitent as I am unsure how to incorporate these changes into v2 (develop branch).

Maybe with a bit of refactoring this approach can be used.

jhoogstraat avatar Mar 01 '22 17:03 jhoogstraat

I'll try to take a look and see if we can make this compatible or I'll create a branch starting from this one and work on how to incorporate these changes in the next version

ikbendewilliam avatar Mar 04 '22 22:03 ikbendewilliam

@jhoogstraat any idea when we can get this merged or when v2 will be done?

vanlooverenkoen avatar Oct 14 '22 11:10 vanlooverenkoen

I think there is not much left for the release of v2. I'll do some tests and check with other issues/prs.

jhoogstraat avatar Oct 20 '22 22:10 jhoogstraat

Thanks, we are looking forward to that so we can update our package and release them to pub.dev as well

vanlooverenkoen avatar Oct 20 '22 22:10 vanlooverenkoen

@jhoogstraat any update on this?

vanlooverenkoen avatar Apr 11 '23 11:04 vanlooverenkoen

@jhoogstraat any more updates? 😁

ikbendewilliam avatar Jul 06 '23 18:07 ikbendewilliam

Hey, I'll take at look at the code. Is this ready to merge?

jhoogstraat avatar Jul 26 '23 05:07 jhoogstraat

We are using this in production for 1,5 years already

vanlooverenkoen avatar Jul 26 '23 06:07 vanlooverenkoen

Yes it's ready to merge and indeed, we've been using it in different projects that are in production

ikbendewilliam avatar Jul 28 '23 14:07 ikbendewilliam

@jhoogstraat any idea when this can be merged?

vanlooverenkoen avatar Aug 16 '23 08:08 vanlooverenkoen