catcher icon indicating copy to clipboard operation
catcher copied to clipboard

Update to Flutter 3

Open ThexXTURBOXx opened this issue 2 years ago • 13 comments

Closes #216 Closes #217 Closes #227 Closes #229

Until this is merged, you can use this fork by declaring a dependency_override:

dependency_overrides:
  catcher:
    git:
      url: https://github.com/ThexXTURBOXx/catcher.git

ThexXTURBOXx avatar May 17 '22 15:05 ThexXTURBOXx

@ThexXTURBOXx - I'm curious, why did you up the compileSDkVerion to compileSdkVersion 32?

michael-woolsey avatar May 19 '22 12:05 michael-woolsey

@michael-woolsey I always do that when I see an outdated compileSdkVersion in order to show that the library is in fact compatible with newer Android versions. When other users just copy paste the example, they might use an outdated version by accident then. So, that specific change does not have something to do with Flutter 3 in particular, but is something that might be nice to have

ThexXTURBOXx avatar May 19 '22 12:05 ThexXTURBOXx

@michael-woolsey I always do that when I see an outdated compileSdkVersion in order to show that the library is in fact compatible with newer Android versions. When other users just copy paste the example, they might use an outdated version by accident then. So, that specific change does not have something to do with Flutter 3 in particular, but is something that might be nice to have

Thanks @ThexXTURBOXx do you know where the latest version is listed online? My GoolgeFu is failing me this morning and I just wanted to read up on it. :)

michael-woolsey avatar May 19 '22 12:05 michael-woolsey

You're welcome :) They are (unofficially) listed for example here: https://apilevels.com/ However, SDK versions marked as BETA can not be used to compile APKs that are compatible with earlier versions. So, always be sure to use the latest full release.

ThexXTURBOXx avatar May 19 '22 12:05 ThexXTURBOXx

Awesome, thanks again!

michael-woolsey avatar May 19 '22 12:05 michael-woolsey

@ThexXTURBOXx Just out of curiosity, is there a particular reason why you chose not to use the ambiguate approach?

luvetter avatar May 25 '22 10:05 luvetter

@luvetter I don't really like that approach, it is messy code in my opinion. Null-safe types are there for a reason, namely, they should never be null when you use them. The ambiguate approach just transforms a type that cannot be null into one that could be null, i.e. you have the same problems as before, but shifted them elsewhere (into the ambiguate method). It should be encouraged by respective libraries to update to Flutter 3 in order to support stay on actively supported versions :)

ThexXTURBOXx avatar May 25 '22 11:05 ThexXTURBOXx

@ThexXTURBOXx Thanks, I understand, that's definitely better than supporting legacy code for an unknown period of time.

luvetter avatar May 25 '22 11:05 luvetter

Nice fix @ThexXTURBOXx , can we please merge this and push a new version to pub.dev? Ping @jhomlala

mikeesouth avatar Jun 09 '22 16:06 mikeesouth

Just bumping this on top.

Tha14 avatar Aug 04 '22 18:08 Tha14

ping @jhomlala

alr2413 avatar Aug 05 '22 11:08 alr2413

how is this not merged yet?

MichalNemec avatar Sep 07 '22 14:09 MichalNemec

Seriously. It has been months now. Just merge this PR please

anton-definit avatar Sep 21 '22 19:09 anton-definit

@jhomlala Can we get this merged please?

Tha14 avatar Oct 05 '22 18:10 Tha14

Sadly, our dear author has had no activity since June 2022, and none of his open source code has seen maintenance. Maybe we can push Flutter to officially incorporate Catcher into the main repository for management, or create a new catcher-plus v1.0.0.

calcitem avatar Oct 06 '22 02:10 calcitem

Looks like this package has been deprecated.

ariefwijaya avatar Oct 31 '22 13:10 ariefwijaya

Yeah. Can any one release catcher-plus?

calcitem avatar Oct 31 '22 13:10 calcitem

It really seems like there won't be any future updates here. I will release my fork to pub tomorrow.

ThexXTURBOXx avatar Oct 31 '22 19:10 ThexXTURBOXx

This project was the best solution I could find for Flutter approx 1yr ago and have been pretty happy using it in a low/moderate usage application. Bit dissapointing to see it not be kept up to date. @jhomlala life got busy or moved on? Thankyou for your efforts anyway and @ThexXTURBOXx pub fork would be good temporary solution. Long term this project needs new ownership and at a minimum for @jhomlala to archive and update readme to the fork. What is the deal for "plus" community projects in flutter?

hampsterx avatar Oct 31 '22 19:10 hampsterx

@hampsterx I am not planning to create a package just for a temporary solution. I would create it to keep it completely up to date from now on in all future Flutter releases. So, I would be the maintainer of a new catcher package from then on.

ThexXTURBOXx avatar Oct 31 '22 19:10 ThexXTURBOXx

great @ThexXTURBOXx

https://github.com/fluttercommunity/plus_plugins

So what is the deal here, all of these are inside a single repo? Ugh..

Not sure you want to use "-plus" name, sounds confusing with above.

hampsterx avatar Oct 31 '22 20:10 hampsterx

Plus plugins is a place for abandoned plugins to be updated by the community with proper support.

I will use the name catcher_2 instead. I have done the same for flutter_web_auth :)

ThexXTURBOXx avatar Oct 31 '22 22:10 ThexXTURBOXx

catcher_2 for flutter 3. oof probably fine, originality is not my forte either :)

hampsterx avatar Oct 31 '22 23:10 hampsterx

The _2 will just mean "continuation". Since I will update catcher also to flutter 4, 5 and so on there :)

ThexXTURBOXx avatar Nov 01 '22 06:11 ThexXTURBOXx

The author did not appear on GitHub for half a year before, and appeared again in the past few days. This is a good thing, and we were worried about it at first. Maybe we can ask the author's opinion.

calcitem avatar Nov 01 '22 06:11 calcitem

Hi 👋 sorry for my absence, I will merge it shortly and release it. Thanks everyone for pushing this topic (@ThexXTURBOXx especially).

jhomlala avatar Nov 01 '22 07:11 jhomlala

Hi @jhomlala and welcome back! I was a bit worried something happened to you. Glad to see you back! In that case, catcher_2 won't be needed :)

ThexXTURBOXx avatar Nov 01 '22 07:11 ThexXTURBOXx

@jhomlala Thank god you are back :-) And thank you @ThexXTURBOXx for keeping catcher up to date in his absence!

anton-definit avatar Nov 01 '22 07:11 anton-definit