betterplayer icon indicating copy to clipboard operation
betterplayer copied to clipboard

[FIX] Remove AVMutableVideoComposition as it was causing black screen…

Open marioloko opened this issue 2 years ago • 4 comments

Remove AVMutableVideoComposition as it was causing black screen iOS on simulator.

Closes #1029. This commit has been tested by several people in the thread.

The main objective of AVMutableVideoComposition was to prevent black screen on physical devices by correcting the tranform of the video track, probably it is not required anymore as we are using UIView with AVPlayerLayer instead of textures. This commit removes the change of video track transform for both physical device and iOS simulator, taking the assumption that the change of transform was only required by AVPlayerItemOutput.

marioloko avatar Nov 01 '22 12:11 marioloko

@marioloko great finding, this PR should be approved @jhomlala it's been a long time ios simulator is showing a black screen

utpal-barman avatar Jan 14 '23 21:01 utpal-barman

@jhomlala can you please check, we need this fix in plugin. @marioloko great work and thanks for fix 👍

SurajLad avatar Jan 18 '23 09:01 SurajLad

@jhomlala ma buddy how is it going we need yo help

user-23xyz avatar Jan 19 '23 19:01 user-23xyz

Wow lol great fix let me try to check

Projecthubdev avatar Sep 11 '23 18:09 Projecthubdev