Johannes Roos

Results 38 comments of Johannes Roos

Great stuff! Theres really a need for a set of fresh eyes on this. Some ideas: From my perspective the schema driven generators (enums, inputs, objects) share a lot of...

Great work! I especially appreciate the "TypeAstGenerator" efforts. That should easily translate to the other plugins as well, and I could see this potentially extend to having a "pure dataclass"...

Whats your idea where styling should be placed? Closer to the ast generation itself?

No thats about it for ClassRegistry ;) I do however think that keeping track of forward references is useful, as every call to update_forward_refs has an impact on module import,...

> > I see we are also becoming fully object-oriented ;) Personally I am not sure if that is really increasing readability (e.g one-line functions like "_type_has_description"). But I am...

Would you be willing to continue on this PR until we have the transition of all plugins to be merged? Or do you feel it would be good to already...

Hi @j-riebe , sorry for the late reply, i was knocked out cold by covid and the brain fog is just lifting :D There is some mature deadlines heading my...

hey @davidzhao , again thanks for the great work. i love the simplicity :heart: . > Did you try to install it on the system? That would be the dream:...

@jakevollkommer hi there! Thanks for submitting the issue! Generally there is an 'Objects plugin' that generates the types from the schema that you could add and that would generate models...