Justin Nguyen

Hey there, these should all be fixed by #2945 :)

Dupe of #2945, see #2944 :)

Some notes, seems like `` needs to be contained somewhere within a ``. `` alone is no longer sufficient. Upon doing this however, items are now disabled with shadcn/ui Edit:...

Figured out the issue, in cmdk changenotes: `The aria-disabled and aria-selected props will now be set to false, instead of being undefined in https://github.com/pacocoursey/cmdk/commit/c57e6b7f81a5796395c7a016d6b1b2aac9591973` It seems that the data-disabled prop...

> I encountered a similar problem when using the Combobox, but in my situation, the issue wasn't that it was unclickable or "disabled"; rather, the application would crash whenever the...

> Any thought on if we should be wrapping `` above `` or below? I believe it should be above `` according to all the examples, additionally enclosing `` but...

Fixed crlf line endings to lf. May be worth documenting this in contributing, but pnpm seems to output files with \r\n instead of just \r on windows machines, ignoring tsconfig...

> The component specific issues have already been fixed in #2626 🤔 After you later added the bug fix from this and the other issue afterwards in a later commit,...

Happy to do a version bump in this PR as well.

> After my initial comment on this PR, I noticed that you made some extra commits, specifically, extra changes that were made in https://github.com/shadcn-ui/ui/pull/2626 that had not been made in...