jhipster-vuejs icon indicating copy to clipboard operation
jhipster-vuejs copied to clipboard

Use sameAs function in confirm password

Open yacosta738 opened this issue 4 years ago • 2 comments

  • Please make sure the below checklist is followed for Pull Requests.

  • [x ] All continuous integration tests are green

  • [ x] Tests are added where necessary

  • [ x] Documentation is added/updated where necessary

  • [ x] Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

changes in validations (Vuelidate): check if the passwords match in the views "change-password" and "reset-password-finish". With the use of the sameAs function it is not necessary to check the password length. The same can be applied in the registry but I leave that to you

yacosta738 avatar Jul 16 '20 02:07 yacosta738

Thanks for your contribution here @yuniel-acosta But maybe you don't know, Vue has been integrated directly to main generator-jhipster so I think it's better to propose your change directly there, instead of this repo

Can you open the same PR there, plz ?

pascalgrimaud avatar Jul 16 '20 05:07 pascalgrimaud

ok i will update the repo generator-jhipster and make the relevant changes. My question is, is this repository going to be obsolete

yacosta738 avatar Jul 16 '20 10:07 yacosta738