jhipster-vuejs icon indicating copy to clipboard operation
jhipster-vuejs copied to clipboard

Map all dates from server in HTTP services

Open snitin315 opened this issue 4 years ago • 7 comments

Fix #482

  • Please make sure the below checklist is followed for Pull Requests.

  • [x] All continuous integration tests are green

  • [x] Tests are added where necessary

  • [x] Documentation is added/updated where necessary

  • [x] Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

snitin315 avatar Jun 16 '20 13:06 snitin315

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 16 '20 13:06 CLAassistant

Thanks for proposing this, @snitin315 But there are still a lot of failures, specially in e2e tests. Can you have a look plz ?

pascalgrimaud avatar Jun 18 '20 07:06 pascalgrimaud

@pascalgrimaud fixed :+1:, not sure about Vue.js / vuejs-fulli18n-es . all tests seem to pass there.

Screenshot at 2020-06-22 13-11-52

snitin315 avatar Jun 22 '20 07:06 snitin315

Last failure is related to:

Jest: "global" coverage threshold for branches (60%) not met: 59.94%

Test Suites: 98 passed, 98 total
Tests:       454 passed, 454 total
Snapshots:   0 total
Time:        52.099 s
Ran all test suites.

Maybe add another test to check all possible condition ?

pascalgrimaud avatar Jun 22 '20 08:06 pascalgrimaud

@pascalgrimaud thanks, all green now :100:

snitin315 avatar Jun 22 '20 08:06 snitin315

Thanks @snitin315 : give me time to review and do some manual tests :)

pascalgrimaud avatar Jun 22 '20 08:06 pascalgrimaud

@hdurix : as you opened the original issue, do you have time to have a quick look plz ?

pascalgrimaud avatar Jun 29 '20 08:06 pascalgrimaud