jhipster-lite
jhipster-lite copied to clipboard
Vue: account with authentication JWT
Fix #897
Codecov Report
All modified lines are covered by tests :white_check_mark:
Comparison is base (
b872ce4
) 100.00% compared to head (b5fc7d2
) 100.00%.
Additional details and impacted files
@@ Coverage Diff @@
## main #7554 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 2616 2623 +7
===========================================
Files 677 680 +3
Lines 11503 11570 +67
Branches 245 245
===========================================
+ Hits 11503 11570 +67
Files | Coverage Δ | |
---|---|---|
...tech/jhipster/lite/generator/JHLiteModuleSlug.java | 100.00% <100.00%> (ø) |
|
...rity/jwt/application/VueJwtApplicationService.java | 100.00% <100.00%> (ø) |
|
...t/vue/security/jwt/domain/VueJwtModuleFactory.java | 100.00% <100.00%> (ø) |
|
...rastructure/primary/VueJwtModuleConfiguration.java | 100.00% <100.00%> (ø) |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
cc @Gnuk do you have some time to take a look at it?
cc @Gnuk do you have some time to take a look at it?
I did a quick review and I have a question:
I'm using most of the time dash -
character inside my folder names to not use camelCase like i see here. I know in java it's in lowercase with underscores _
for multiple words. In JS environment i see more kebab-case usage. So maybe it's interesting to use kebab-case for multiple work in a package like name and keep the usage of CamelCase like Java in the FileName itself.
I don't know if in JHipster Lite we have already made a choice about this.
cc @Gnuk do you have some time to take a look at it?
I did a quick review and I have a question:
I'm using most of the time dash
-
character inside my folder names to not use camelCase like i see here. I know in java it's in lowercase with underscores_
for multiple words. In JS environment i see more kebab-case usage. So maybe it's interesting to use kebab-case for multiple work in a package like name and keep the usage of CamelCase like Java in the FileName itself.I don't know if in JHipster Lite we have already made a choice about this.
For java packages it's _
, -
for the others
any update ?
Sorry about this, I'll try to give it a try and have a look at this PR Thanks for your patience :)
Sorry about this, I'll try to give it a try and have a look at this PR Thanks for your patience :)
No problem, Take your time :)