jhipster-dotnetcore icon indicating copy to clipboard operation
jhipster-dotnetcore copied to clipboard

Published 20 hours ago • verified publisher icon jhipster

Reduce code smells on sonar

Open nicolas63 opened this issue 4 years ago • 7 comments

Overview of the feature request

We have 150 code smells on our sample (https://sonarcloud.io/dashboard?id=jhipster_jhipster-sample-app-dotnetcore)

we can quickly resolve several of them (like visibility)

Related issues or PR
  • [x] Checking this box is mandatory (this is just to show you read everything)

nicolas63 avatar Sep 26 '20 19:09 nicolas63

Hi, I would like to solve this issue.

vinibeloni avatar Sep 26 '20 23:09 vinibeloni

Hey @nicolas63, I would like to contribute to this.

swastikchugh avatar Sep 27 '20 00:09 swastikchugh

Hi, @swastikchugh you can share this task with @vinibeloni or you can take an other issue ( maybe #383 )

nicolas63 avatar Sep 27 '20 07:09 nicolas63

Hey @vinibeloni, how about we divide this one, you can maybe fix upto "src/.../Data/Extensions/DbSetExtensions.cs" according to the code smells list?

swastikchugh avatar Sep 29 '20 18:09 swastikchugh

Hi @swastikchugh , oh sorry, I didn't see your comment, but I opened to my pull request , and this file I didn't change it haha so you can resolve that issue.

vinibeloni avatar Oct 02 '20 00:10 vinibeloni

@vinibeloni your pull request must be on this repo, the sample project was generated so we don't have to touch the code.

nicolas63 avatar Oct 02 '20 05:10 nicolas63

Yes, but how ?

nicolas63 avatar Oct 04 '20 17:10 nicolas63