generator-jhipster icon indicating copy to clipboard operation
generator-jhipster copied to clipboard

Release generator-jhipster 8.7.2

Open mraible opened this issue 1 year ago • 5 comments

Overview of the feature request

I think releasing a new minor version with recent bug fixes would be good.

  • Don't generate Docker Compose configuration when no services are detected https://github.com/jhipster/generator-jhipster/pull/27437 and https://github.com/jhipster/generator-jhipster/pull/27380
  • Downgrade Sass to avoid warnings when running npm start https://github.com/jhipster/generator-jhipster/pull/27528
  • Use Bootstrap v4 themes for Vue https://github.com/jhipster/generator-jhipster/pull/27465
  • Resolve Faker 9 breaking changes https://github.com/jhipster/generator-jhipster/pull/27368

FWIW, Spring Boot 3.3.5 is due October 24. I'd be happy to do a minor release before and after that update.

Motivation for or Use Case

Because developers have had issues with the new Docker support.

Related issues or PR
  • [x] Checking this box is mandatory (this is just to show you read everything)

mraible avatar Oct 16 '24 12:10 mraible

@mshima Do you think we should wait for the last topics in https://github.com/jhipster/generator-jhipster/issues/27433?

DanielFran avatar Oct 16 '24 12:10 DanielFran

@mshima Do you think we should wait for the last topics in #27433?

Not a blocker.

mshima avatar Oct 16 '24 14:10 mshima

Some blueprints based on 8.7.1 needs to be released. Maybe a JHipster release should be announced the day after with blueprints that are already released.

mshima avatar Oct 16 '24 21:10 mshima

Are you suggesting we do some blueprint releases with 8.7.1 support in the next week before we worry about 8.7.2?

mraible avatar Oct 16 '24 23:10 mraible

I suggest to release 8.7.2 and blueprints based on 8.7.2 and announce together.

mshima avatar Oct 16 '24 23:10 mshima

I suggest to release 8.7.2 and blueprints based on 8.7.2 and announce together.

I'm OK with this. I can release 8.7.2 this weekend. When you say "announce," do you mean announcing it on social media or publishing the release on GitHub?

Publishing the release to npmjs.com will be necessary to update the blueprints, but I can hold off publishing the release on jhipster.tech and github.com until the blueprints are updated. It'd be fun to announce everything on Halloween (Oct 31), but I realize that's mostly a US holiday.

mraible avatar Oct 24 '24 13:10 mraible

I tried to add support for Java 23 tonight before releasing 8.7.2. However, the CI builds were so slow that I ran out of time. I'll revisit it in the morning.

mraible avatar Oct 28 '24 04:10 mraible

I'm starting the release now.

mraible avatar Oct 28 '24 16:10 mraible

The 8.7.2 release has been published to npmjs.com.

@mshima Please proceed with updating blueprints to use this release.

mraible avatar Oct 28 '24 16:10 mraible

@mraible we need to release 8.7.2, generators folder wasn't included.

mshima avatar Oct 28 '24 16:10 mshima

No, it's another problem I will take a look.

mshima avatar Oct 28 '24 16:10 mshima

@mraible can you tag 8.7.3 with https://github.com/jhipster/generator-jhipster/pull/27710?

mshima avatar Oct 28 '24 17:10 mshima

I have to take my wife to surgery now so won't be able to do this until this evening, in approximately 6 hours.

mraible avatar Oct 28 '24 19:10 mraible

Best wishes.

mshima avatar Oct 28 '24 19:10 mshima

Just so I know what to do: #27710 needs to be merged and then a new release (8.7.3) needs to be made?

mraible avatar Oct 28 '24 21:10 mraible

Just so I know what to do: #27710 needs to be merged and then a new release (8.7.3) needs to be made?

Yes, unfortunately blueprints tests are broken.

mshima avatar Oct 28 '24 21:10 mshima

Does that mean that 8.7.2 will work for creating apps, but not for blueprints?

mraible avatar Oct 29 '24 00:10 mraible

Does that mean that 8.7.2 will work for creating apps, but not for blueprints?

Yes. Only blueprints testing are broken. Unfortunately this use case is only tested when sources are not available (released package or installed using git)

mshima avatar Oct 29 '24 00:10 mshima

OK. I'm going to continue releasing 8.7.2 and then I'll release 8.7.3. I won't announce either one.

mraible avatar Oct 29 '24 03:10 mraible

https://github.com/jhipster/generator-jhipster/releases/tag/v8.7.2

mraible avatar Oct 29 '24 03:10 mraible

Bounty claimed: https://opencollective.com/generator-jhipster/expenses/226594

mraible avatar Nov 02 '24 20:11 mraible