generator-jhipster
generator-jhipster copied to clipboard
Fix failing schema validation for mysql when boolean/enum is used
Fix #25421
Please make sure the below checklist is followed for Pull Requests.
- [ ] All continuous integration tests are green
- [ ] Tests are added where necessary
- [ ] The JDL part is updated if necessary
- [ ] jhipster-online is updated if necessary
- [ ] Documentation is added/updated where necessary
- [ ] Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: pmverma
:x: pmohan
pmohan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
@pmverma Can you please fix conflicts?
Hi @mraible I have fixed the conflicts. While this PR solves the issue with boolean and ENUM for MySQL, multiple other datatypes are failing the Hibernate schema validation. Some are visible in CI tests in this PR as well.
Please see https://github.com/jhipster/generator-jhipster/issues/26761
I would prefer to hold this until https://hibernate.atlassian.net/browse/HHH-18257 is solved.
HHH-18257 is still open. Bummer.
@pmverma https://hibernate.atlassian.net/browse/HHH-18257 refers to https://hibernate.atlassian.net/browse/HHH-16531, which has been closed: enum issues have been fixed in https://github.com/hibernate/hibernate-orm/pull/8411
Can you confirm, please?