generator-jhipster
generator-jhipster copied to clipboard
bump mysql from 8.2.0 to 8.3.0
Fix #24919
Please make sure the below checklist is followed for Pull Requests.
- [ ] All continuous integration tests are green
- [ ] Tests are added where necessary
- [ ] The JDL part is updated if necessary
- [ ] jhipster-online is updated if necessary
- [ ] Documentation is added/updated where necessary
- [ ] Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.
@DanielFran @mshima it seems that with 1.19.4 version of org.testcontainers:mysql it works, but I think that applying the version directly in files (like in this PR) is not the good way... WDYT?
@qmonmert we have already defined same version in BOM project, this is strange that it is needed to overwrite here too...
@DanielFran on JHLite it was related https://github.com/jhipster/jhipster-lite/commit/f0c16c3e68f6b7b97bda2a87920b837492e0af7d
@DanielFran without specify the version #25008 ❌
I think this is a bug at jhipster-bom, it's not overriding correctly the testcontainer-bom. Maybe because jhipster-bom uses spring-boot-dependencies as parent.
I think this is a bug at jhipster-bom, it's not overriding correctly the testcontainer-bom. Maybe because jhipster-bom uses spring-boot-dependencies as parent.
In the past, defining the spring-boot bom then any other after that allow to overwrite any spring-boot dependency. Starting on some specific maven version the behaviour change and we try to fix it with https://github.com/jhipster/jhipster-bom/pull/1457 Maybe it needs more investigation
It looks like all tests are passing now.
Superseded by https://github.com/jhipster/generator-jhipster/pull/24919