generator-jhipster icon indicating copy to clipboard operation
generator-jhipster copied to clipboard

WIP: Revisit - Update password reset page to use only react-form capabilities

Open hide212131 opened this issue 2 years ago • 1 comments
trafficstars

A PR to continue the discussion from https://github.com/jhipster/generator-jhipster/pull/19560

Updates standard forms to use wrapped leaf element instead of a form wrapper.

  • let the user mix his own components with JH wrapped elements
  • compatible with latest react version (which forbids the use of useState and useEffect within a lib from what I've tested)
  • use something that he better knows to use
  • No need to maintain the react-jhipster forms code which is a bit... difficult to understand

I've made changes to the codes by @Tcharl to incorporate the following features:

  • Rebased on the latest main branch.
  • Updated to the newest reactstrap (v9.2).
  • Fixed several issues.
  • Modified checkbox and select functionalities to pass the e2e tests.

Currently, all tests pass when running npm run e2e.

Refer to the following information:

hide212131 avatar Aug 12 '23 07:08 hide212131

While I certainly support the direction of these code changes, I have a few suggestions. I will write after this.

hide212131 avatar Aug 12 '23 08:08 hide212131