generator-jhipster icon indicating copy to clipboard operation
generator-jhipster copied to clipboard

Consul support uses a deprecated token query parameter

Open mraible opened this issue 2 years ago • 8 comments
trafficstars

Overview of the issue

I created a microservices architecture using my Micro Frontends demo script today and noticed there are a lot of deprecation warnings from Consul:

[WARN]  agent.http: This request used the token query parameter which is deprecated and will be removed in Consul 1.17: 
logUrl=/v1/catalog/services?token=<hidden>
Motivation for or Use Case

It'd be nice if there weren't deprecation warnings in log files.

Reproduce the error

Following my demo script and you'll see the warnings after you start the full stack with docker compose up.

JHipster Version(s)

main branch as of June 26, 2023.

mraible avatar Jun 26 '23 22:06 mraible

There is also no OIDC support since its an enterprise feature in Consul

deepu105 avatar Jun 29 '23 16:06 deepu105

It says the token query parameter is deprecated and will be removed in Consul 1.17. Should we be concerned?

mraible avatar Jun 29 '23 17:06 mraible

I added a bug bounty to get this fixed.

mraible avatar Jul 08 '23 20:07 mraible

This appears to be an issue with the unmaintained consul-api library used by spring-cloud-consul for http requests.

Issue on spring-cloud-consul Issue on consul-api Issue for Spring Cloud Consul to migrate away from consul-api: spring-cloud-consul

Survival1sm avatar Aug 04 '23 13:08 Survival1sm

Should this be worked on or already done? @mraible

BrayanMnz avatar Aug 14 '24 15:08 BrayanMnz

This is still an issue as far as I know.

mraible avatar Aug 14 '24 18:08 mraible

Assign this to me, I will take a look at it @mraible

BrayanMnz avatar Aug 15 '24 19:08 BrayanMnz

@BrayanMnz Done!

mraible avatar Aug 27 '24 14:08 mraible