generator-jhipster icon indicating copy to clipboard operation
generator-jhipster copied to clipboard

Rename angularX configuration option to angular

Open qmonmert opened this issue 2 years ago • 4 comments

Fix #19354


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

qmonmert avatar Aug 07 '22 17:08 qmonmert

Tagging as major since jdl will break with angularX value.

mshima avatar Aug 08 '22 12:08 mshima

For backward compatibility it will be better to allow both angular and angularx for now. Update the documentation and and show warning when used. Then completely remove angularx in a later version

JusticeN avatar Aug 09 '22 23:08 JusticeN

@JusticeN The target is for v8

DanielFran avatar Aug 10 '22 08:08 DanielFran

Thus is it possible to create the V8 branch?

Tcharl avatar Aug 10 '22 18:08 Tcharl

This PR needs a rebase.

mraible avatar Aug 16 '22 21:08 mraible