generator-jhipster
generator-jhipster copied to clipboard
jhipster
migrate to docker-compose v2.
Closes https://github.com/jhipster/generator-jhipster/issues/19462
Please make sure the below checklist is followed for Pull Requests.
- [ ] All continuous integration tests are green
- [ ] Tests are added where necessary
- [ ] The JDL part is updated if necessary
- [ ] jhipster-online is updated if necessary
- [ ] Documentation is added/updated where necessary
- [ ] Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.
@mraible the PR is open so I will not forget about it, but I should work on it for v8 and refactor the files generation. There is a lot of work to be done.
@DanielFran those files are test samples, which should be generated when the generator templates changes. But they are not updated, and I can’t blame because I myself never remember it’s existence. They should be removed.
If you look at the PR I’ve removed it’s use at docker-compose generator. We should do the same for others generators. But it’s a big task to check kurbernetes related generators and others related to workspaces and docker. We should implement https://github.com/jhipster/generator-jhipster/issues/19980 and then a similar task for base-docker.
@mshima Yes I know. When we update image versions we sometimes forget to update those files... wanted to fix that issue. But if they are not used anymore, ok, we can then remove them after. Thanks
For image versions we should add a version map for docker and Java like we have for node. When running tests, we should replace the versions with placeholders.