generator-jhipster
generator-jhipster copied to clipboard
ClientForwardController Change Regex Mapping
closes #18039
Please make sure the below checklist is followed for Pull Requests.
- [ ] All continuous integration tests are green
- [ ] Tests are added where necessary
- [ ] The JDL part is updated if necessary
- [ ] jhipster-online is updated if necessary
- [ ] Documentation is added/updated where necessary
- [ ] Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci
label, you can still see CI build result at your branch.
@maiido : can you update the test plz? Otherwise the CI will fail
@maiido : can you update the test plz? Otherwise the CI will fail
I have tested this change in a built application and this makes the admin interface unavailable - if we push f5 or use a direct link... so please also make sure that stuff like that will continue to work. ;-)
@maiido : can you update the test plz? Otherwise the CI will fail
I have tested this change in a built application and this makes the admin interface unavailable - if we push f5 or use a direct link... so please also make sure that stuff like that will continue to work. ;-)
Hi, it's strange, I don't have this issue. My test : Compile with maven (profiles dev+webapp) launch webservice in intellij as an application I have access to http://localhost:8080 api+webapp, and if i go to http://localhost:8080/login and press f5 after no issue.
@maiido : can you update the test plz? Otherwise the CI will fail
I have tested this change in a built application and this makes the admin interface unavailable - if we push f5 or use a direct link... so please also make sure that stuff like that will continue to work. ;-)
Hi, it's strange, I don't have this issue. My test : Compile with maven (profiles dev+webapp) launch webservice in intellij as an application I have access to http://localhost:8080 api+webapp, and if i go to http://localhost:8080/login and press f5 after no issue.
well, but the admin / management interface is behind something like this:
http://localhost:8080/admin/logs
@OmarHawk you are right, it's not ok
@OmarHawk you are right, it's not ok
so, right now, the test is testing the wrong thing ;-)
Also, we probably would prevent accessing entities via ids as part of the address bar URL, like this:
http://localhost:8080/entity/111/view
Closing due to lack of response.