generator-jhipster icon indicating copy to clipboard operation
generator-jhipster copied to clipboard

ClientForwardController Change Regex Mapping

Open maiido opened this issue 2 years ago • 7 comments

closes #18039


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

maiido avatar Mar 25 '22 16:03 maiido

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 25 '22 16:03 CLAassistant

@maiido : can you update the test plz? Otherwise the CI will fail

pascalgrimaud avatar Mar 29 '22 16:03 pascalgrimaud

@maiido : can you update the test plz? Otherwise the CI will fail

I have tested this change in a built application and this makes the admin interface unavailable - if we push f5 or use a direct link... so please also make sure that stuff like that will continue to work. ;-)

OmarHawk avatar Apr 07 '22 15:04 OmarHawk

@maiido : can you update the test plz? Otherwise the CI will fail

I have tested this change in a built application and this makes the admin interface unavailable - if we push f5 or use a direct link... so please also make sure that stuff like that will continue to work. ;-)

Hi, it's strange, I don't have this issue. My test : Compile with maven (profiles dev+webapp) launch webservice in intellij as an application I have access to http://localhost:8080 api+webapp, and if i go to http://localhost:8080/login and press f5 after no issue.

maiido avatar Apr 11 '22 07:04 maiido

@maiido : can you update the test plz? Otherwise the CI will fail

I have tested this change in a built application and this makes the admin interface unavailable - if we push f5 or use a direct link... so please also make sure that stuff like that will continue to work. ;-)

Hi, it's strange, I don't have this issue. My test : Compile with maven (profiles dev+webapp) launch webservice in intellij as an application I have access to http://localhost:8080 api+webapp, and if i go to http://localhost:8080/login and press f5 after no issue.

well, but the admin / management interface is behind something like this:

http://localhost:8080/admin/logs

OmarHawk avatar Apr 11 '22 09:04 OmarHawk

@OmarHawk you are right, it's not ok

maiido avatar Apr 11 '22 10:04 maiido

@OmarHawk you are right, it's not ok

so, right now, the test is testing the wrong thing ;-)

Also, we probably would prevent accessing entities via ids as part of the address bar URL, like this:

http://localhost:8080/entity/111/view

OmarHawk avatar Apr 11 '22 15:04 OmarHawk

Closing due to lack of response.

mraible avatar Aug 17 '22 08:08 mraible