generator-jhipster icon indicating copy to clipboard operation
generator-jhipster copied to clipboard

Composite primary key (again)

Open yelhouti opened this issue 3 years ago • 11 comments

Overview of the feature request

Now that we have better support for the generation of primary keys (jdl...), ans that blueprints have been using them for a little while, I think we should start using them in the server code (java + liquibase) then once the server is stable enough implement them in the frontend.

Again before starting to work on this, I am pinging the people that showed must interest/opposition last time to see what you think: @mshima @DanielFran @jdubois @deepu105 @PierreBesson @gmarziou I apologize in advance in forgot anybody.

More info on what have been done and discussed until now can be found here: https://github.com/jhipster/generator-jhipster/issues/7112

yelhouti avatar Feb 18 '22 17:02 yelhouti

@DanielFran thank you for tagging this v8, do I understand correctly that this is a go ahead ? or does anyone have any objection ? ( Looking at you @mshima :stuck_out_tongue: )

yelhouti avatar May 23 '22 13:05 yelhouti

It is tagged to "V8" to be discussed internally if we should or not include it on the roadmap...

DanielFran avatar May 23 '22 13:05 DanielFran

@DanielFran thank you for the info, can I take part in the discutions ? I contacted https://groups.google.com/g/jhipster-dev few weeks ago but never received a reply.

yelhouti avatar May 23 '22 14:05 yelhouti

@yelhouti : how did you contact the group ? as it's in read only for external members ?

pascalgrimaud avatar May 23 '22 16:05 pascalgrimaud

@pascalgrimaud there is a contact owners and managers that allows you to send an email. Screenshot from 2022-05-23 18-38-48

yelhouti avatar May 23 '22 16:05 yelhouti

We already support composite id in the internals. If the template change is simple enough it can be merged. No need for v8 tag.

mshima avatar May 23 '22 16:05 mshima

I would like to be able to generated the server code two, which as you might think impacts almost all the entity-server (and liquibase) files. @mshima what do ou think, can something like this ever be merged ?

yelhouti avatar May 23 '22 16:05 yelhouti

I have a Cassandra implementation for composite primary keys (including clustering keys). It is working for my local blueprint with version JHipster version 7.6.0. I would like to contribute it to the JHipster community. I would need help in merging the code with the latest JHipster (version 7.9.3).

amarpatel-xx avatar Jan 23 '23 02:01 amarpatel-xx

@amarpatel-xx same for me, I have a version here updated to 7.9.3 https://github.com/yelhouti/generator-jhipster/tree/composite-key but I need to rebase it again.

yelhouti avatar Jan 23 '23 03:01 yelhouti

This issue is stale because it has been open for too long without any activity. Due to the moving nature of jhipster generated application, bugs can become invalid. If this issue still applies please comment otherwise it will be closed in 7 days

github-actions[bot] avatar Nov 29 '23 00:11 github-actions[bot]

Just keeping this open if no one minds, until I have time to rebase on top of 8.0.0

yelhouti avatar Nov 29 '23 02:11 yelhouti

This issue is stale because it has been open for too long without any activity. Due to the moving nature of jhipster generated application, bugs can become invalid. If this issue still applies please comment otherwise it will be closed in 7 days

github-actions[bot] avatar May 28 '24 00:05 github-actions[bot]

I have successfully made a composite primary key blueprint for JHipster 8.6.0 cassandra. Please see reference here: https://github.com/amarpatel-xx/jhipster-cassandra-composite-primary-key-example

I have open sourced the blueprint and the example to show my gratitude to the open source community.

amarpatel-xx avatar Jul 16 '24 23:07 amarpatel-xx