stream-http icon indicating copy to clipboard operation
stream-http copied to clipboard

Fix TypeError: t.body is null

Open garronej opened this issue 8 months ago • 0 comments

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Problem started to arise with empty response body with latest version of Firefox (I think).

Here is the diff that solved my problem:

diff --git a/node_modules/stream-http/lib/response.js b/node_modules/stream-http/lib/response.js
index 91d1900..aeab6b3 100644
--- a/node_modules/stream-http/lib/response.js
+++ b/node_modules/stream-http/lib/response.js
@@ -75,6 +75,12 @@ var IncomingMessage = exports.IncomingMessage = function (xhr, response, mode, r
 				return
 			} catch (e) {} // pipeTo method isn't defined. Can't find a better way to feature test this
 		}
+
+		if (!response.body) {
+			resetTimers(true);
+			self.push(null)
+			return
+		}
 		// fallback for when writableStream or pipeTo aren't available
 		var reader = response.body.getReader()
 		function read () {

Update of: https://github.com/jhiesey/stream-http/pull/110

This issue body was partially generated by patch-package.

garronej avatar Oct 09 '23 17:10 garronej