AudioWorks icon indicating copy to clipboard operation
AudioWorks copied to clipboard

Support for tags that aren't explicitly supported

Open ghost opened this issue 5 years ago • 5 comments

Hi,

If I issue Get-AudioFile '.\test.flac' | Export-AudioFile LameMP3 ., tags that aren't explicitly supported are not carried over, "Disc number" and "Total discs", for instance. Nor are they visible in the metadata property of a TaggedAudioFile object.

Wouldn't it be a good idea to support all tags, including non-standard ones?

ghost avatar Jul 17 '20 10:07 ghost

It's hard to do as the tags are mapped between audio formats, and some (like ID3) are very particular about what's allowed and how they should be formatted. I'm certainly open to adding specific additional fields like the above.

jherby2k avatar Jul 17 '20 15:07 jherby2k

If for example the below Tags are present/set in the source ...

Disc                       : 1
DiscCount                  : 1

after conversion (no matter what Encoder/TagVersion/TagEncoding) they are showing

Disc                       : 0
DiscCount                  : 0

not NULL, not Empty -> "0"

It seems like it's not setting them, because "TrackCount" is also set to "0".. TrackCount can't be smaller than "Track", can it ? "Track" however is set correctly

nonspin avatar Aug 08 '20 13:08 nonspin

There is no way its setting the Disc and DiscCount fields at all. What are you using to read the tags? Can you attach the file in question?

jherby2k avatar Aug 08 '20 15:08 jherby2k

Sometimes there are multiple discs (volumes). Track number is given within of the volume, not of total. There are m4a and mp3 examples. Zipped, as Guthub doesn't allow m4a and mp3 extensions. test.zip

regs01 avatar Sep 29 '20 12:09 regs01

Sometimes there are multiple discs (volumes). Track number is given within of the volume, not of total. There are m4a and mp3 examples. Zipped, as Guthub doesn't allow m4a and mp3 extensions. test.zip

Yes, i see that these have a disk # recorded in them. Currently, AudioWorks will strip those when re-writing the tags. I am going to address this in v1.1 by expanding the known tag dictionary. An alternative would be to simply save and restore unrecognized tags verbatim, but i'm not sure i want that feature - I like that AudioWorks re-writes the tag from scratch, as it can correct mistakes. Also that wouldn't help in a transcoding scenario.

jherby2k avatar Oct 03 '20 02:10 jherby2k