react-native-debugger icon indicating copy to clipboard operation
react-native-debugger copied to clipboard

[Relay] Consider adding the new relay-devtools extension?

Open alloy opened this issue 6 years ago • 9 comments

Thanks for a great tool!

Recently mentions of relay-devtools have appeared in the Relay Modern docs. While the repos are not public yet, the Chrome extension can already be installed.

I was hoping that you may consider including that already or, if not, if you could point me at where I need to update code to include this extension myself?

alloy avatar Sep 13 '17 10:09 alloy

Thanks for the info! Due to the old relay plugin in react-devtools may doesn't support Relay Modern, I think we should support the new devtools.

We need to waiting for the Electron app public, and hoping it like react-devtools that exported the app core package, or just fork it. Here is code for include react-devtools.

Also, these are the implementation in RN:

Currently the registerDevtoolsPlugin server port will conflict if __REACT_DEVTOOLS_PORT__ are set (we used it for multiple debugger support), need to temporarily change it. I might report an issue to react-native.

jhen0409 avatar Sep 13 '17 15:09 jhen0409

Oh yeah, that sounds a lot more involved than I had hoped for right now. Thanks for taking it into consideration, though, let me know if I can/should test something out for you at some point!

alloy avatar Sep 13 '17 17:09 alloy

The standalone app of Relay DevTools is published here but source code not public yet, and the problem have been fixed in https://github.com/facebook/react-native/commit/bd70f3ab3b2807ce3648548d3e70577d09c4e3c2.

jhen0409 avatar Sep 28 '17 14:09 jhen0409

The source code for the devtools is now available at https://github.com/relayjs/relay-devtools

@jhen0409 what is necessary to include it into react-native-debugger? I probably can get a PR going for that.

JCMais avatar Apr 12 '18 19:04 JCMais

i'm going to put a pr together - i've been working on the standalone version on my own branch but it'd be great to just integrate it here.

modosc avatar Jan 18 '19 20:01 modosc

is #298 a reasonable template to follow for adding a new tool?

modosc avatar Jan 25 '19 19:01 modosc

Any news on this? Having this available would be awesome.

milosa avatar Apr 26 '19 21:04 milosa

Any updates?

caleb272 avatar Sep 24 '19 18:09 caleb272

Any updates? The official relay-devtools is not working as expected on React Native.

SpaghettiC0des avatar Nov 12 '20 10:11 SpaghettiC0des