Jason Held comments

Results 172 comments of


                                            Jason Held

trafficstars

exception when use m2m clear() function

Hi. I'm not positive on having a new event_type but definitely agree on getting this fixed. Send up your PR when you have some time and let's find out if...

Performance issue. FK fields are being queried to check to see if data changed

You may be right. I haven't audited that code path. If that's the case, can you write up a PR which adjusts the code to check if the field is...

Not logging all models

You can setup an easyaudit logger. Can you see if something is having an error via the log?

Not logging all models

Curious are any of your models using a non-integer primary key?

Better handle transactions in pre-save

Interesting fix. Looks good. Can you also add a test case?

Better handle transactions in pre-save

@Etenil can you check if the `pre_save` logic is still in need of change based on current master?

ImproperlyConfigured error raised in auth_signals.py when using multiple databases

Do you have time in the short term to create a PR?

Avoid DB savepoints if no audit is going to be created

So I do agree that if we can avoid certain paths in the flow, we should, and I'm still concurring that this is a good change, but is it _actually_...

Arbitrary object primary key field

Yeah, I was wondering about this, too. We could use a `CharField` to open that up, though I do wonder if there is another way to do it.

Arbitrary object primary key field

One reason that IntegerField or CharField are nice is because we get to just reference the value by its value, not link it as a foreign/primary key. If the object...