drupalextension icon indicating copy to clipboard operation
drupalextension copied to clipboard

Ambiguous match when translating step "@Given I am at :path" to Spanish

Open jose-carmona opened this issue 8 years ago • 2 comments

I've tried to translate to Spanish the step "@Given I am at :path" and this is the result of the test:

Cuando estoy en "admin/structure/types"    # features/i18n/es/d8.feature:18
   Ambiguous match of "estoy en "admin/structure/types"":
   to `(que )estoy en :path` from Drupal\DrupalExtension\Context\MinkContext::assertAtPath()
   to `/^estoy en "(?P<page>[^"]+)"$/` from Drupal\DrupalExtension\Context\MinkContext::visit()

Looks like the MinkContext::assertAtPath of DrupalExtension is the same of MinkContext::visit of MinkExtension.

I think the correct way to proceed would be to eliminate steps "@Given I am at :path" and "@When I visit :path" of MinkContext of DrupalExtension to add them to MinkContext of MinkExtension.

What do you think?

jose-carmona avatar Dec 12 '17 19:12 jose-carmona

I think the reason it still exists here is the mink folks were hesitant to add it... could there be a way to translate it differently, or not translate the one used here at all?

jhedstrom avatar Dec 18 '17 23:12 jhedstrom

I used a different sentence ("(que )estoy en la URL :path") to translate the step.

Please, let me make a little PR to reference this issue in the code before close it.

jose-carmona avatar Dec 23 '17 20:12 jose-carmona