jhdcs comments

Results 26 comments of


                                            jhdcs

[WIP] Testing adding clang-tidy to github actions

Or not. Just the UI being strange.

[WIP] Testing adding clang-tidy to github actions

Ah, yes, it needs a `compile_commands.json` file to have been generated (which we can get via `-DCMAKE_EXPORT_COMPILE_COMMANDS=ON`). I'll try and add in those modifications and see where this leaves us.

[WIP] Testing adding clang-tidy to github actions

[clang_tidy_output.txt](https://github.com/ros2/rosbag2/files/6696887/clang_tidy_output.txt) For our information, this is what Clang-Tidy is returning when I run it locally.

[WIP] Testing adding clang-tidy to github actions

> FYI. `Clang-Tidy` built-in in `CLion` IDE and highlights all these findings by the red color by default and even sometimes suggesting quick fixes or giving extra info about issue....

[WIP] Testing adding clang-tidy to github actions

> I notice that a significant amount of the output is from generated code in `build/` - is there a way to only run on the "written" code in `src/`?...

Revisit rosbag2 internal data structures

> Regardless of that - rosbag2 needs to solve the "old bag problem" in some way - we will have to make changes at some point, it seems inevitable. I...