Jean-Hadrien Chabran

I added support for Date, as you can see there : http://github.com/jhchabran/searchlogic/blob/2d3d7ac5d7a267c8a367bf0066683a9212efc1de/lib/searchlogic/search.rb It lacks support Time class and maybe some cosmetic changes, but it basically works. ( an expectation was...

Separating it in a module is basically doable, but it will leads to hook Search#conditions=, Search#method_missing, which seems to me to be a lot of work for just one line...

cc @quinnhare and @taylorsperry

#37615 is nearly complete, closing this to clean things up.

cc @vrto, we did another pass with @bobheadxi and trimmed down our first draft into this ticket

@bobheadxi we're invited you to a quick sync call later on today, quick heads up!

@mnotti about > Let clickhouse.stdDriver support driver.ConnBeginTx. I went around a similar problem by wrapping the original driver, you can check it here: https://github.com/sourcegraph/sourcegraph/pull/39300/files#diff-bc34aa163694ecf12848f338a0eccb4a222a5d61dc30061d597fc78f8238c906R86

Good catch 👍

thought: we probably should add owners to CI jobs, so we can report who is owning what (please challenge this)

Was chatting with @mrnugget this morning and this came up. @marekweb I don't know where you're putting your wip work, but I think that if it's not already in there...