discard

discard copied to clipboard

robertp

Wrap discard methods in a transaction

8

**NOTE:** This PR doesn’t currently include tests (I tested against the provided Ruby script). Should this code be something you all want in the project, I will by all means...

thewatts

Run callbacks inside of the same transaction

5

**Describe the bug** Currently the callbacks such as after_discard are run outside of the discarded model's transaction. This can lead to unexpected behavior where, for example, the model is discarded...

jeffblake

after_discard_commit

1

Do you think a after_discard_commit makes sense, which is triggered just as after_destroy_commit ? Reason is, that we have some queue triggers that should only be fired when the transactin...

quorak

discarded? value on validations and callbacks

1

I'm trying to understand an issue we have on Solidus: https://github.com/solidusio/solidus/pull/3202. These are two specs that describe the behavior we had with discard 1.0.0: ```ruby describe 'discarded? value on callbacks/validations'...

kennyadsl

While working with the discard gem I noticed that you can't discard already discarded records. There wasn't any mention of this in the docs and the error message wasn't very...

Sam-Robin

Fix a very minor doc typo on the undiscard! method

1

Discard -> Undiscard !

mattbnz