John Hawthorn

Results 39 comments of John Hawthorn

> It is both significantly faster than this gem in general and doesn't have concurrency issues. Maybe that could be a source of inspiration for how to solve this? (I'd...

Just to update this with some things I missed on a first pass. There are two types of callcaches w/r/t their lifetime: "regular" callcaches, which are cached on a class...

Hello! Could you make sure you are wrapping each unit of work (the body of your handler function) with `Rails.executor.wrap` https://guides.rubyonrails.org/threading_and_code_execution.html#wrapping-application-code. Using executor.wrap (which a standard Rails application will wrap...

Seems like a good improvement! I am a little uncertain about us adding a feature to the RubyTracker that the ERBTracker does not have, as currently that's what is enabled...

> To be fair, the assumption is that with `block_given?` you can often avoid declaring `&block`: That's another point in favour of removing the linter, which tells you to replace...

I don't think `JSON` should perform this validation. It will hurt performance a lot and it's not something we can fully guarantee to users. This may cover simple cases but...

I don't think the JSON gem should support this. It sounds like a reasonable thing to do for Sidekiq but is too specific for a general JSON gem (hard to...

@erimicel This change seems fine to me, but would you be able to provide a reproduction repo? It's hard to see why this would fail (or why it would work...

Thanks! Sorry for the slow response. If a reproduction can be provided on any supported version without additional patches please feel free to file a new issue.