nbflow icon indicating copy to clipboard operation
nbflow copied to clipboard

pydoit compatibility for nbflow

Open camillescott opened this issue 9 years ago • 3 comments

Hello there!

I like to use pydoit as my build system; it supports Python3 and is quite extensible. This PR adds a module to nbflow for pydoit.

The folder doit-example shows how it works. It uses a dodo.py file, which follows a similar pattern to the scons example:

from nbflow.doit import create_build_tasks

def task_nbflow():
    yield from create_build_tasks(['analyses'])

Major kudos for your arch making this really easy to write!

Todos:

  • [ ] Needs tests ;)
  • [x] Works only with Python 3, which conflicts with he scons module and example notebooks. See here for instructions on putting Python 2 and 3 kernels side by side.
  • [ ] Should possibly be its own package, something like nbflow-doit
  • [x] A couple bugs have been fixed which I need to push downstream (more PRs incoming)
  • [ ] If keeping in same project, update README

Cheers, Camille

camillescott avatar Jul 15 '16 21:07 camillescott

Thanks! Let's loop @joestubbs too who was thinking of working on exactly this as well.

jhamrick avatar Jul 15 '16 22:07 jhamrick

Thanks for looping me in! I wrote a pydoit.py module with a setup function as we discussed, and the original workflow example builds successfully, but I hadn't added any additional tests. My implementation doesn't add pydoit to the requirements; rather, it assumes the user has installed it themselves and has their own dodo.py file (or task loader) that they can complement with the setup function.

If this would be of use I'm happy to make it available - just let me know.

joestubbs avatar Jul 15 '16 23:07 joestubbs

Hi! Just watched the Scipy 2016 talk. Great Idea! I would also much prefer to use pydoit instead of Scons. Best, Ajasja

ajasja avatar Aug 08 '16 14:08 ajasja