Joe Hamman

Results 587 comments of Joe Hamman

@wietsefranssen - I'll make comments on https://github.com/UW-Hydro/VIC/pull/231.

These timing tables don't make any sense. Or they do and all sorts of things are going wrong. For one ```| Final Time | 1.50401e+09``` is more than the total...

No, by the VIC timing infrastructure. see #520 .

@bartnijssen - CESM doesn't tell VIC the stop dates so those variables are probably unset.

@PhilippBuehler - please provide the requested [issue information](https://github.com/UW-Hydro/VIC/blob/master/.github/ISSUE_TEMPLATE.md).

@PhilippBuehler -can you run with the code on the develop branch - make sure to rebuild the code. I think we already fixed this: https://github.com/UW-Hydro/VIC/blob/develop/vic/drivers/shared_image/src/vic_init.c#L1230-L1241 xref: #701

@PhilippBuehler - It seems this section of code may not be doing what we intended: https://github.com/UW-Hydro/VIC/blob/26f88313953420caf07fe5844fe8f72327f96fc1/vic/drivers/shared_image/src/vic_init.c#L1232-L1241 I'll mark this as a bug but it would be great if you can...

@PhilippBuehler - you'll need to open a pull request. A general comment though, I think `-1e6` is probably too permissive. See this discussion for more details: https://github.com/UW-Hydro/VIC/pull/701#discussion_r106278828. I don't recall...

@PhilippBuehler - what dataset are you working with? My suspicion is that your `Cv` variable does not sum exactly to one.

@sandgrules - Glad you were able to get this to work. Something seems odd with your found solution so I think we'd be happy to take any contributions to improve...