Joe Hamman
Joe Hamman
This is not quite all passing yet but I changed this from WIP to ready for review anyway. Our goal is to get this wrapped up in the next couple...
I added a number of folks as reviewers to this because I want to make sure it gets prompt review. We're still iterating on the Zarr-Python side but it would...
In https://github.com/pydata/xarray/pull/9552/commits/26081d4f950f39f7bbc24cea264d5aff24db730f, I added the `donfig` and `crc32c` deps.
I'm going to spend some time today working on the last few failures here. Some things I'm noticing that will need some attention: 1. In the datatree tests, we need...
@TomAugspurger - a thought that may help limit the scope of this PR. We may consider punting on full datatree support for zarr-v3 in this PR and fix that up...
> What exactly is the scenario/version where this doesn't work? I would like to release a version of Xarray where you can still use DataTree to open a Zarr V2...
> xarray/tests/test_backends.py::test_zarr_storage_options is tricky to test. We should be able to just pass through storage_options to the call to zarr.open_group. Let's skip this test with v3.
@pydata/xarray - are there others that are hoping to review this before it goes in? Noting that most of the surface area here is in the tests, the actual code...
> but mypy doesn't like that my 2 cents... we should not get hung up on this right now. a) there are plenty of other failures in the upstream-dev-mypy check...
👏 Thanks all! Especially @TomAugspurger for doing the lion's share of the work here.