typetools icon indicating copy to clipboard operation
typetools copied to clipboard

Published 20 hours ago • verified publisher icon jhalterman

Java module-info.java

Open nhojpatrick opened this issue 5 years ago • 1 comments

I'm happy to do the work but after some discussion at apache commons, I would propose a major version bump for adding module-info into typetools.

  1. Any downstream projects using class scanners potentially won't understand module-info so will break projects.
  2. I propose using Multi Release Jar, so; 2.1) Make min java version requirement 1.8 2.2) Update build to have src/main/java11/module-info.java (only that single java11 file) 2.3) Compile module-info.java into META-INF/versions/11/module-info
  3. I don't propose supporting any other versions apart from 1.8 and 11, which are both LTS, afterwards others could be added if useful.
  4. I'm happy to do the alterations and submit a PR for v1.x.x

Thoughts?

nhojpatrick avatar Mar 03 '20 10:03 nhojpatrick

Why do you think a multi-release jar would be necessary, and similar for the 1.8 requirement?

jhalterman avatar Mar 13 '20 02:03 jhalterman