typetools
typetools copied to clipboard
Fix bugs when working with JRebel
Ignore JRebel inserted methods in getMemberRef Resolve issue: #50
Codecov Report
Merging #51 into master will decrease coverage by
1.64%. The diff coverage is20%.
@@ Coverage Diff @@
## master #51 +/- ##
============================================
- Coverage 76.71% 75.07% -1.65%
- Complexity 105 106 +1
============================================
Files 2 2
Lines 335 345 +10
Branches 98 100 +2
============================================
+ Hits 257 259 +2
- Misses 34 40 +6
- Partials 44 46 +2
| Impacted Files | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| ...rc/main/java/net/jodah/typetools/TypeResolver.java | 78.14% <20%> (-2%) |
98 <1> (+1) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 0bd6f1f...94e2c7d. Read the comment docs.
I realize this might be better if it's a configuration, so that we don't have to hardcode JRebel things that might change, instead JRebel users can configure them. Ex:
// Filters methods that might be matched when resolving lambda type arguments
TypeResolver.addLambdaMemberFilter(Predicate<Member> lambdaMemberFilter)
Thoughts?
Got it. I've added the addLambdaMemberFilter method to make the client add a custom filter.
PTAL
The CI failed cause by install-jdk.sh, would you like to check it.