lyra icon indicating copy to clipboard operation
lyra copied to clipboard

Get rid of static executor service

Open acogoluegnes opened this issue 7 years ago • 2 comments

See https://github.com/jhalterman/lyra/issues/80#issuecomment-334460764

acogoluegnes avatar Oct 05 '17 14:10 acogoluegnes

ChannelHandler also uses this executor, But I think the problem can be solved when close/abort are invoked. If they are invoked from ConnectionHandler class, then the executor should be stopped.

DimaGolomozy avatar Oct 05 '17 17:10 DimaGolomozy

The static executor service scopes all the connections created in the process. Stopping it for a connection would make the recovery impossible for all the other connections created in the process.

acogoluegnes avatar Oct 06 '17 14:10 acogoluegnes