James Hagborg
James Hagborg
I encountered a similar issue today, but more severe. `C_Initialize` ends up getting called with garbage parameters. Here's the portion of memory where the `CK_C_INITIALIZE_ARGS` should be, right before `C_Initialize`...
One downside to the API above the mutable borrow means it is not possible to interleave calls to `find_next` with calls to other session operations. I think it's possible to...
Another downside is that we can't handle errors from `C_FindObjectsFinal`, since it's called from `drop`. An alternative that would allow this is to use some sort of type-state: when we...
On Thu, 2022-11-24 at 01:14 -0800, Wiktor Kwapisiewicz wrote: > While looking at your proposed API it makes a striking resemblance to > the Iterator API. Just wondering, have you...
On Thu, 2022-12-01 at 00:48 -0800, Wiktor Kwapisiewicz wrote: > LGTM. It kind of bothers me that None and Some(vec![]) are basically > the same state but using Option has...
Updated to return just a vector, rather than an option of vector.
Neat. I was thinking that an iterator interface would be a separate struct that wraps a `FindObjects`, created from a separate method like `Session::find_objects_iter()`. That way the user doesn't need...
On Tue, 2022-12-06 at 02:57 -0800, Ionuț Mihalcea wrote: > > +// Search 10 elements at a time > +const MAX_OBJECT_COUNT: usize = 10; > Any reason for this choice?...
On Tue, 2022-12-06 at 02:57 -0800, Ionuț Mihalcea wrote: > Hmmmmm... Would it be possible to add a method to FindObjects, > something like finalize, that just takes ownership of...
On Thu, 2022-12-08 at 02:43 -0800, Ionuț Mihalcea wrote: > One question I wanted to raise is: how much time do you have/are you > willing to put into resolving...