vault-java icon indicating copy to clipboard operation
vault-java copied to clipboard

Recommendation: Please encapsulate in a package

Open jentfoo opened this issue 9 years ago • 3 comments

I would highly recommend migrating all your classes out of the default package space and into something specific for your project. I know I don't want my app's default package space to be cluttered by bringing in dependencies that do things like that.

Just my .02, feel free to discard.

jentfoo avatar Feb 05 '16 22:02 jentfoo

@jentfoo That make sense! I'll make sure to refactor it as soon as I get time. If you've already done this for your personal project please submit it upstream and I would be happy to merge it.

jhaals avatar Feb 09 '16 16:02 jhaals

I have moved the source and tests into the package, let me know how you would like to proceed with merge

nandhusriram avatar Feb 20 '16 19:02 nandhusriram

looks good!

jhaals avatar Feb 21 '16 19:02 jhaals