cloud_mdir_sync icon indicating copy to clipboard operation
cloud_mdir_sync copied to clipboard
verified publisher icon jgunthorpe

Update messages.py to fix bug

Open wang2357 opened this issue 1 year ago • 3 comments

Added return val to fix a bug in the get_header method.

wang2357 avatar Oct 04 '24 05:10 wang2357

Great, can you add a signed-off-by to follow the Developer Certificate of Origin? https://developercertificate.org/

jgunthorpe avatar Oct 23 '24 16:10 jgunthorpe

There is a new issue, with the same file, which is that the _read_header sometimes fail with headers that contain foreign characters. This is fixed by making sure value return by emsg.get(hdr) is converted to a string.

wang2357 avatar Feb 19 '25 15:02 wang2357

can you rebase this and add a signed-off by to the commit that has missed it? It looks OK to me thanks

jgunthorpe avatar Feb 25 '25 20:02 jgunthorpe