bulma icon indicating copy to clipboard operation
bulma copied to clipboard

Published 20 hours ago • verified publisher icon jgthms

Fixes #3655

Open AadiRana911 opened this issue 1 year ago • 0 comments

This is a bugfix.

Issue#3655 -> Update sass/components/navbar.sass:6 The variable $navbar-height is set to 3.25rem (52px) by default. However the navbar height changes to 3.5rem (56px) as soon as a button is added!

Proposed solution

Change default navbar height from 3.25rem to 3.5rem.

There is an alternate solution as well. We can reduce the default button size so that the navbar doesn't get disturbed

Testing Done

Unit testing has been done by linking my test project locally with bulma

I have:

  1. Cloned the bulma repo.
  2. Created a new react project named PGReact.
  3. Linked bulma locally with PGReact.
  4. Wrote this piece of code in App.js
    <body class="has-navbar-fixed-top">
      <nav class="navbar is-fixed-top has-background-light">
        <a class="navbar-item">Link</a>
        <div class="navbar-item">
          <a class="button">Button</a>
        </div>
      </nav>
    </body>
  1. Commented the code written between <nav> and </nav>
  2. The height of navbar didn't get disturbed

Changelog updated?

No.

AadiRana911 avatar Jun 21 '23 09:06 AadiRana911