bulma icon indicating copy to clipboard operation
bulma copied to clipboard

Issue with Tabs component in RTL

Open evokelektrique opened this issue 2 years ago • 3 comments

When I was trying to use the Tabs component in a hero layout while I was using bulma-rtl.css and I noticed a small problem with the border-radius of the tabs elements when the tabs container has a .is-boxed class, It seems like we don't need a different border-radius for RTL version, since the codes in the referenced codes below are trying to make it upside down instead of RTL or LTR, Then it's better to have only a single border-radius for both versions.

https://github.com/jgthms/bulma/blob/a6cd4f302edcd60d438c9dad1db4b39ab08da7a9/sass/components/tabs.sass#L97-L100

Problem:

Problem

Expectation:

Fix

I'll try and open a pull request for a fix.

evokelektrique avatar Nov 01 '21 12:11 evokelektrique

Good point. The boxed tabs shouldn’t differ in RTL.

jgthms avatar Nov 01 '21 13:11 jgthms

I'll try and open a pull request for a fix.

@jgthms Oh I appreciate you taking your time to read this problem, As I promised, I have provided a solution(#3438) for the issue, I hope it's acceptable.

evokelektrique avatar Nov 01 '21 13:11 evokelektrique

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 01 '22 01:05 stale[bot]