bulma icon indicating copy to clipboard operation
bulma copied to clipboard

findDarkColor() not changing the colour

Open airblade opened this issue 5 years ago • 7 comments

This is about Bulma.

I'm not sure if it's a bug or by design.

Overview of the problem

This is about the Bulma CSS framework I'm using Bulma 0.8.0

Description

I want to get a dark version of #e20e76.

Bulma's findDarkColor() function doesn't seem to work; in contrast findLightColor() does appear to work.

Is the colorLuminance() function supposed to produce the same result as SASS's lightness() function? In this case colorLuminance(#e20e76) is roughly 0.19 whereas lightness(#e20e76) is 47%. Which is what $target-l turns out to be here.

Steps to Reproduce

  1. Set a SASS property value to findDarkColor(#e20e76). E.g.
body
  color: findDarkColor(#e20e76)

Expected behavior

I expect the resulting colour to be darker than the given one.

Actual behavior

The resulting colour is unchanged, i.e. #e20e76.

airblade avatar Oct 29 '19 11:10 airblade

I created an issue here too with a workaround https://github.com/jgthms/bulma/issues/2805

basejump avatar Feb 11 '20 00:02 basejump

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 09 '20 01:08 stale[bot]

This is still an issue in v0.9.0.

airblade avatar Aug 10 '20 09:08 airblade

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 11 '21 01:06 stale[bot]

This is still an issue in v0.9.2.

airblade avatar Jun 11 '21 10:06 airblade

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 18 '22 19:04 stale[bot]

Still an issue in v0.9.4.

airblade avatar Apr 20 '22 14:04 airblade