bulma icon indicating copy to clipboard operation
bulma copied to clipboard

Fix inconsistent input[disabled] color in Safari. Fixes #2355

Open dsernst opened this issue 5 years ago • 4 comments

This is a bugfix.

Proposed solution

Safari is rendering disabled input fields with faded text.

Instead of the Bulma default #7a7a7a (48% luminosity), the input text renders at #cecece (81% luminosity).

Multiple users reported confusion, thinking the <input disabled> value= was instead placeholder= text, because it was so faded.

Bulma is already choosing to override the default <input disabled> text color.

That setting simply isn't taking effect in Safari & iOS Safari.

Screenshots of the bug (top correct, bottom incorrect):

This PR fixes it.

Tradeoffs

This adds a bit of browser-specific attributes to the codebase. A case could be made that's better handled by normalize.css.

Testing Done

Confirmed to work in production.

Changelog updated?

No.

dsernst avatar Jun 04 '19 02:06 dsernst

Is there anything I can do to help this get merged? Do you think the change log should be updated as well?

MartinMa avatar Dec 11 '20 18:12 MartinMa

Is this going to be merged at some point? This is still an issue in bulma 9.3 it seems

larsk2009 avatar Nov 30 '21 13:11 larsk2009

Adding to the choir, just encountered this issue in our products. Anything stopping it?

henriksonnergard avatar May 25 '22 12:05 henriksonnergard

how is this still unmerged, another client complaining about this

w3sami avatar Jun 20 '23 09:06 w3sami