jgroups-raft icon indicating copy to clipboard operation
jgroups-raft copied to clipboard

InMemoryLog entries on repeated counter perf runs keep on growing

Open franz1981 opened this issue 2 years ago • 5 comments

While running single node repeated tests with InMemoryLog performance degrades over runs because LogEntry on InMemoryLog::entries keep on growing.

franz1981 avatar Apr 27 '22 20:04 franz1981

InMemoryLog is supposed to be used only by unit tests. However, we could replace entries with ArrayRingBuffer if you wanted

belaban avatar May 02 '22 11:05 belaban

I would rather disable to set it by user(s) if is not well-behaving - and just it to exist on test packages

People that doesn't want to fsync can just use the file log on tmpfs without fsync

franz1981 avatar May 02 '22 11:05 franz1981

ah, ok, good idea. I'll move it to the test package then!

belaban avatar May 02 '22 11:05 belaban

This means #153 is moot then?

belaban avatar May 02 '22 11:05 belaban

On second thought, InMemoryLog might be useful to test a setup that doesn't write to disk, ie. when testing RTTs. I'll leave InMemoryLog where it is and rather implement this issue and #153. Not very high prio, though...

belaban avatar May 03 '22 08:05 belaban