drawio icon indicating copy to clipboard operation
drawio copied to clipboard

c4 shape properties not inline with display order

Open Philzen opened this issue 2 years ago • 2 comments

Preflight Checklist

  • [x] I agree to follow the Code of Conduct that this project adheres to.
  • [x] I have searched the issue tracker for a feature request that matches the one I want to file, without success

First of all: thanks for building this awesome tool and even including c4 models with it. Currently comes in extremely handy and poses an invaluable asset to the architecture planning process for the project i'm currently working on. :heart:

Problem description

grafik

  • The order of the fields (in the editor popup on double-click as well as the tooltip that you can see) is not aligned with the display of the boxes. That is a little bit confusing when editing b/c one would expect to enter c4Name first, then c4Technology (if existent) and then c4Description (which is sort of an optional detail)
    Maybe this could be aligned in a separate commit when this is fixed in a patch branch.
  • c4Type should actually not be editable at all
    I'm not sure if that is possible to achieve with properties (are read-only properties possible?). I may actually prefer to see this hard-coded as it is a fixed property of the boxes as defined in the c4model methodology. However at least some mapping / field would need to be maintained for exporting / interconnecting with other systems i guess.

draw.io version

The above screenshot were taken from the vs code plugin "Draw.io Integration" v1.6.4 which includes draw.io 16.0.0 as a git submodule.

Also checked https://jgraph.github.io/drawio/src/main/webapp/index.html which exposes the same behaviour.

Philzen avatar Feb 04 '22 00:02 Philzen

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. See the FAQ for more information.

stale[bot] avatar Aug 06 '22 12:08 stale[bot]

Ping :ping_pong:

Philzen avatar Aug 06 '22 15:08 Philzen

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. See the FAQ for more information.

stale[bot] avatar Apr 08 '23 13:04 stale[bot]

Bump :fist_oncoming:

Philzen avatar Apr 10 '23 16:04 Philzen

Fixed in 24.2.0.

davidjgraph avatar Mar 26 '24 16:03 davidjgraph