drawio-desktop icon indicating copy to clipboard operation
drawio-desktop copied to clipboard

Window titlebar is missing context menu for, e.g., moving the window to another desktop

Open raphendyr opened this issue 3 years ago • 5 comments

Preflight Checklist

  • [x] I agree to follow the Code of Conduct that this project adheres to.
  • [x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug Before removing the native window title bar, I was able to use (right click) context menu to do action for the window. In KDE this includes, but is not limited to, move the window to another desktop, to another screen, move, resize and so on.

However, after removing the native window border, I'm unable to open this menu.

To Reproduce Steps to reproduce the behavior:

  1. Install drawio 15.7.3 and open it.
  2. Right click on the title bar
  3. No menu is opened

Expected behavior When I right click, a menu is opened.

Screenshots Right click is supposed to open menu like this image

draw.io version (In the Help->About menu of the draw.io editor):

  • draw.io version 15.7.3

Desktop (please complete the following information): Debian GNU/Linux bookworm/sid KDE Frameworks 5.86.0

Additional context This problem was introduced as a result of fixing #91 . I didn't spend time to find the actual commit yet.

In addition of the context menu, the title bar misbehaves with double click, which is reported in #775.

raphendyr avatar Nov 15 '21 20:11 raphendyr

I would be fine to set an environment variable before starting the application, which specifies if native borders should be enabled or not (e.g. enabled, disabled or auto (selects default based on operating system)). I can then set this environment variable in the .desktop file, which is relatively simple for the enduser to do.

For me, returning to native borders is acceptable solution, as it also solves placement of buttons on window border and double click behaviour.

This mechanic is used to e.g. enable Wayland for Firefox and things like that.

raphendyr avatar Nov 22 '21 13:11 raphendyr

+1 for making native borders an optional setting.

VSCode is a great example of this. They let users use the custom style if they want, but users also have the option to use a native feel (configurable in the program's settings) as well.

image

cachandlerdev avatar Mar 04 '22 03:03 cachandlerdev

Apart from being a great application, it is indeed pretty annoying that it behaves so much differently than other applications on my KDE desktop. It looks totally weird without the borders and I can't use my configured actions for them, e.g. move to another desktop or just click the titlebar with the middle mouse button to move it to the background.

As there are no borders and my configured window shadows also don't apply, it doesn't stand out from other windows, so if I got a browser with a website with a white background behind it, it looks like drawio is on that website.

Please make the native titlebar configurable.

kid4git avatar Aug 31 '22 09:08 kid4git

Apart from being a great application, it is indeed pretty annoying that it behaves so much differently than other applications on my KDE desktop.

Since you are using KDE, you can define a window rule to force frame and titlebar.

Screenshot_20220831_111300

But I agree that it would be better to make this configurable without resorting to hacks.

maetthu avatar Aug 31 '22 09:08 maetthu

Since you are using KDE, you can define a window rule to force frame and titlebar.

@maetthu Awesome, you are my hero! Thanks.

And if I hit that "Collapse/Expand" toggle on the top right, it looks even more like a native application.

kid4git avatar Aug 31 '22 12:08 kid4git

Could you test whether 20.7.4 improves this issue please?

davidjgraph avatar Dec 23 '22 15:12 davidjgraph

@davidjgraph thanks. It's perfect now :+1:

I close this as fixed in 20.7.4 or before.

raphendyr avatar Dec 28 '22 22:12 raphendyr