Segfault on macOS app termination

[JosefWN]

Preflight Checklist

• [x] I agree to follow the Code of Conduct that this project adheres to.
• [x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

You must agree to search and the code of conduct. You must fill in this entire template. If you delete part/all or miss parts out your issue will be closed.

Describe the bug Although I'm very grateful for the fix in https://github.com/jgraph/drawio-desktop/issues/1127, the latest version seems to produce a segfault every time the app is terminated. I tried removing all app settings, resetting the app to its initial state, but to no avail.

To Reproduce

1. Open draw.io
2. Close draw.io

Expected behavior The program should terminate without segfault.

draw.io version (In the Help->About menu of the draw.io editor):

• draw.io version 22.1.16

Desktop (please complete the following information):

• macOS Sonoma 14.2.1

Additional context

Truncated crash report

-------------------------------------
Translated Report (Full Report Below)
-------------------------------------

Process:               draw.io [2873]
Path:                  /Applications/draw.io.app/Contents/MacOS/draw.io
Identifier:            com.jgraph.drawio.desktop
Version:               22.1.16 (22.1.16)
Code Type:             ARM-64 (Native)
Parent Process:        launchd [1]
User ID:               501

Date/Time:             2024-01-09 06:19:49.7407 +0100
OS Version:            macOS 14.2.1 (23C71)
Report Version:        12
Anonymous UUID:        DA9544CB-44A0-4BD4-C94D-227D93CE92E4


Time Awake Since Boot: 1200 seconds

System Integrity Protection: enabled

Crashed Thread:        0  CrBrowserMain  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000010
Exception Codes:       0x0000000000000001, 0x0000000000000010

Termination Reason:    Namespace SIGNAL, Code 11 Segmentation fault: 11
Terminating Process:   exc handler [2873]

VM Region Info: 0x10 is not in any region.  Bytes before following region: 4329127920
      REGION TYPE                    START - END         [ VSIZE] PRT/MAX SHRMOD  REGION DETAIL
      UNUSED SPACE AT START
--->  
      __TEXT                      102094000-102098000    [   16K] r-x/r-x SM=COW  ...MacOS/draw.io

Thread 0 Crashed:: CrBrowserMain Dispatch queue: com.apple.main-thread
0   libobjc.A.dylib               	       0x18c295420 objc_msgSend + 32
1   Electron Framework            	       0x10b80ba1c node::FreeArrayBufferAllocator(node::ArrayBufferAllocator*) + 275328
2   Electron Framework            	       0x10b80b468 node::FreeArrayBufferAllocator(node::ArrayBufferAllocator*) + 273868
3   Electron Framework            	       0x10b797cfc v8::CodeEvent::GetScriptName() + 6308
4   AppKit                        	       0x1902505e4 -[NSApplication _terminateFromSender:askIfShouldTerminate:saveWindows:] + 124
5   AppKit                        	       0x1902504dc __52-[NSApplication(NSAppleEventHandling) _handleAEQuit]_block_invoke + 52
6   AppKit                        	       0x190355764 ___NSMainRunLoopPerformBlockInModes_block_invoke + 44
7   CoreFoundation                	       0x18c73f5e4 __CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK__ + 28
8   CoreFoundation                	       0x18c73f4f8 __CFRunLoopDoBlocks + 356
9   CoreFoundation                	       0x18c73e330 __CFRunLoopRun + 812
10  CoreFoundation                	       0x18c73d9ac CFRunLoopRunSpecific + 608
11  HIToolbox                     	       0x196cec448 RunCurrentEventLoopInMode + 292
12  HIToolbox                     	       0x196cec0d8 ReceiveNextEventCommon + 220
13  HIToolbox                     	       0x196cebfdc _BlockUntilNextEventMatchingListInModeWithFilter + 76
14  AppKit                        	       0x18ff1a8a4 _DPSNextEvent + 660
15  AppKit                        	       0x1906f4980 -[NSApplication(NSEventRouting) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 716
16  AppKit                        	       0x18ff0dd50 -[NSApplication run] + 476
17  Electron Framework            	       0x10e9bf318 node::GetArrayBufferAllocator(node::IsolateData*) + 17973960
18  Electron Framework            	       0x10e9bd184 node::GetArrayBufferAllocator(node::IsolateData*) + 17965364
19  Electron Framework            	       0x10e975ed4 node::GetArrayBufferAllocator(node::IsolateData*) + 17673860
20  Electron Framework            	       0x10e93cabc node::GetArrayBufferAllocator(node::IsolateData*) + 17439340
21  Electron Framework            	       0x10dacf164 node::GetArrayBufferAllocator(node::IsolateData*) + 2310420
22  Electron Framework            	       0x10dad0bfc node::GetArrayBufferAllocator(node::IsolateData*) + 2317228
23  Electron Framework            	       0x10daccad4 node::GetArrayBufferAllocator(node::IsolateData*) + 2300548
24  Electron Framework            	       0x10b969288 v8::internal::compiler::BasicBlock::set_loop_header(v8::internal::compiler::BasicBlock*) + 13948
25  Electron Framework            	       0x10b96a3f0 v8::internal::compiler::BasicBlock::set_loop_header(v8::internal::compiler::BasicBlock*) + 18404
26  Electron Framework            	       0x10b96a220 v8::internal::compiler::BasicBlock::set_loop_header(v8::internal::compiler::BasicBlock*) + 17940
27  Electron Framework            	       0x10b968acc v8::internal::compiler::BasicBlock::set_loop_header(v8::internal::compiler::BasicBlock*) + 11968
28  Electron Framework            	       0x10b968c6c v8::internal::compiler::BasicBlock::set_loop_header(v8::internal::compiler::BasicBlock*) + 12384
29  Electron Framework            	       0x10b63a2f0 ElectronMain + 128
30  dyld                          	       0x18c2e10e0 start + 2360

[JosefWN]

Small remark: Also, the dialog window displaying the progress of the update from the previous version of draw.io is blank (completely white). If it weren't for the fact that the update went quick, I would have thought that something had frozen.

[JosefWN]

Hello @davidjgraph! Great to see it was solved, will the fix be out in the next release?