sass-extract
sass-extract copied to clipboard
Support for Dart Sass (possibility for using custom implementation)
@jgranstrom This should not be too difficult to implement. I would be happy to send a PR for this.
How terrible would something like this be?
let sass;
try {
sass = require('node-sass');
} catch(err) {
try {
sass = require('sass');
} catch(err2) {
throw new Error("Unable to find a sass implementation to use");
}
}
FWIW, I tried symlinking node-sass
to sass
, and that wasn't enough. Got some other nebulous error using that approach. So, I would think supporting both might involve more than just replacing the import
statements.
@avindra The basic implementation is ready, but unfortunately we still have some things to fix, before every test gets passed.
@bencergazda Thanks for the heads up. That branch is here for anyone who looking:
https://github.com/jgranstrom/sass-extract/compare/master...bencergazda:feat-dart-sass
Would be a great feature! Thanks @bencergazda
@bencergazda what is the situation of this? Is there anything I could help with?
@Aapzu Sorry for the delay. Unfortunately, I didn't have time during the past months to fix the remaining failing tests. Any help is welcome.
Please feel free to fork https://github.com/bencergazda/sass-extract/tree/feat-dart-sass (starting from 91a9c3d9), I am going help if needed in anything.
@bencergazda I fixed the remaining failing tests, but I had to use a dirty trick https://github.com/bencergazda/sass-extract/compare/feat-dart-sass...athorcis:feat-dart-sass
@Athorcis Super, thanks! I will check the changes as soon as I have a little time.
@Athorcis I looked over the files and they seem to be OK to me. Thanks for fixing the tests! Would you open a PR in @bencergazda/sass-extract? I might ask for documenting a few lines, but otherwise I would be happy to merge it.
@bencergazda Here's the PR : bencergazda/sass-extract#3
Wow, feel free to PR
@jgranstrom Created PR #51