react-native-sketch icon indicating copy to clipboard operation
react-native-sketch copied to clipboard

Published 20 hours ago • verified publisher icon jgrancher

Android implementation

Open stefannew opened this issue 6 years ago • 7 comments

I was working on a cross-platform POC with some sketch functionality and I was loving the way this performed in iOS, but was saddened to see that it was lacking an Android implementation. I checked out the closed PRs and it appears there was one in the works, but was closed in favour of another library? It didn't make much sense to me to pull in two libraries for the same problem, so I decided to take a stab at an Android implementation.

The drawing itself isn't as smooth as the iOS side of things because I haven't implemented the same smooth freehand drawing techniques detailed in the readme. I'm going to look into that this weekend, or perhaps as a follow-up PR (if this gets merged).

So far I've simply exposed the API and kept it the same as the iOS side of things:

android

It's definitely on the larger side due to the nature of the additions but take a look and let me know what you think.

Thanks! 🎈

stefannew avatar May 12 '18 01:05 stefannew

Hey @jgrancher, any thoughts on this? I have a side project and would love to have Android support.

ttmarek avatar Jul 13 '18 14:07 ttmarek

@stefannew How does it going? Any process by now?

leiz-me avatar Sep 13 '18 13:09 leiz-me

@leiz-me Progress on what? No one has reviewed the PR.

stefannew avatar Sep 13 '18 13:09 stefannew

@stefannew Yes, that's what I also want to know. Looks like this repo is not active right now. You mentioned that you were working on the smooth freehand drawing, just want to know any idea now. I have a project that wants to use this repo as the sketch component, but it currently only supports iOS.

Thank you for your reply and your work.

leiz-me avatar Sep 13 '18 14:09 leiz-me

Oh, I see - sorry for the confusion! Yeah, I was going to think about implementing the smooth freehand stuff once I got some feedback on the PR at large - it's a big one, but like you say I guess this particular repo is inactive. I wonder if the owner would be interested in transferring it to someone else for maintenance.

stefannew avatar Sep 13 '18 14:09 stefannew

Yes, I am planning to fork this project and use your code directly for one small function on my app.

Thanks!

leiz-me avatar Sep 13 '18 14:09 leiz-me

@stefannew @leiz-me Any chance you forked this repo and now have a secret repo waiting for us? 😄

ghoshabhi avatar May 03 '19 21:05 ghoshabhi