jgostick comments

Results 116 comments of


                                            jgostick

An error is reported when this case is executed (relative_permeability_metrics.ipynb)

OK, thanks. Just wanted to make sure your problem wasn't from something old or still in development. Looking at your error it seems that flow inlets have not been set....

An error is reported when this case is executed (relative_permeability_metrics.ipynb)

In V3 we have removed all the pre-written metrics in favor of detailed examples with explanations. Since V3 will be released soon, I am going to close this issue.

Size factor models return negative numbers for conduits with "engulfing" pores

Perhaps we could add a new `pore.safe_diameter` which is the largest sphere that can safely be used in any conductance model?

Logging overrides global logging behaviour

closed by PR #2531

Pore-scale model factory

I think I see some value here. I'm going to reopen it and add it to future enhancements.

`Statoil` import should add reservoir pores instead of deleting reservoir throats

The solution to this requires finding the x,y,z locations for the fictitous pores. Maybe these could be calculated by triangulation knowing the throat lenghts and positions of other end? On...

`Statoil` import should add reservoir pores instead of deleting reservoir throats

After some thought: 1. We should continue to delete these reservoir pores upon importing, so that things work with openpnm 2. We should keep the `add_reservoir_pore` method (maybe move it...

`Statoil` import should add reservoir pores instead of deleting reservoir throats

If we are going to continue deleting the reservoir pores, then we can keep `network_from_statoil` as it is now and remove the `network_to_statoil` function for now, then add this functionality...

Change models to only accept one keyword for each prop (temperature, instead of pore_temperature and throat_temperature)

There is some value to that suggestion for sure

Change models to only accept one keyword for each prop (temperature, instead of pore_temperature and throat_temperature)

not sure about interpolating, but we should change args to remove the ``throat_`` and ``pore_`` business. Just ``diffusivity`` and the function looks up ``'pore.' + diffusivity'`` and ``'throat.' + diffusivity'``....