Fix frozen string exception

Open arronmabrey opened this issue 5 years ago • 2 comments

I had an issue on ruby 1.9.3 strip!': can't modify frozen String (RuntimeError)

This happens because the version number passed in is frozen and the downstream code mutates it, causing an exception.

Jan 04 '21 19:01 arronmabrey

I'm hoping to get this merged, so I can remove my fork and use the gem directly. I think this will help others on ruby 1.9.3. Please let me know if there are any concerns, and hopefully I can address them. :-)

Jan 22 '21 15:01 arronmabrey

Update on this, we've had it in QA for about ~2 months and it's been performing well. We are headed to production with this change. Getting this merged is still a cleanup task, and I just wanted to confirm the patch is doing well. 👍

Mar 02 '21 15:03 arronmabrey